Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading capistrano before setting application name breaks #149

Closed
KieranP opened this issue Apr 9, 2018 · 2 comments
Closed

Loading capistrano before setting application name breaks #149

KieranP opened this issue Apr 9, 2018 · 2 comments

Comments

@KieranP
Copy link

KieranP commented Apr 9, 2018

Should be able to load capistrano datadog before setting name, as common practice is to put all require lines at the top of files before the set commands. However:

Loading before name set

require "capistrano/datadog"
set :application, "app"
triggering load callbacks
Please specify the name of your application, set :application, 'foo'

Loading after name set

set :application, "app"
require "capistrano/datadog"
triggering load callbacks
* 2018-04-09 14:47:44 executing `app'
@github-actions
Copy link

github-actions bot commented Jan 4, 2020

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of this project.

  2. Comment that the issue is still reproducible and include updated details requested in the issue template.

@github-actions github-actions bot added the stale Stale - Bot reminder label Jan 4, 2020
@gzussa gzussa removed the stale Stale - Bot reminder label Jan 15, 2020
@gzussa gzussa reopened this Jan 15, 2020
@zippolyte
Copy link
Contributor

Hey @KieranP

I couldn't reproduce this issue with the latest version 1.38 of dogapi-rb. Is it still happening for you ?

I tried with a sample capistrano project, with the deploy.rb looking like so

require "capistrano/datadog"

set :application, "my_app_name"
set :repo_url, "git@example.com:me/my_repo.git"
set :datadog_api_key, "xxx"

and cap staging deploy executed fine.

Closing in the meantime, feel free to reopen and provide more details on how to reproduce if this happens again.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants