Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open question: should OpenTelemetry payloads have recent timestamps? #305

Closed
GeorgeHahn opened this issue Sep 14, 2022 · 2 comments
Closed

Comments

@GeorgeHahn
Copy link
Contributor

OpenTelemetry consumers may drop payloads with distant timestamps. This could cause significant performance differences if some consumers drop payloads more aggressively than others.

This is a tradeoff. Timestamp generation should optimally be deterministic. That precludes the use of system time based bounds. The best we can do while maintaining determinism may be to bound timestamps to a far larger block of time, like the current decade.

@blt
Copy link
Collaborator

blt commented Sep 14, 2022

Oh, interesting. In any of the other payloads that have timestamps we do have fully deterministic times, but you're right that consumers may drop old timestamps and improve performance thereby. Hmm. Maybe we leave it fully deterministic for now and just document real well that we're going to be kicking out possibly ancient or far-future timestamps?

@GeorgeHahn
Copy link
Contributor Author

I agree, I think that's the best option for now.

One other option is to add configs for timestamp generation. Generating times within a range would be powerful. That would add enough complexity that I prefer to wait until someone needs it though.

@blt blt closed this as completed Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants