-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assertion failure with cursor #10
Comments
bonnefoa
added a commit
that referenced
this issue
May 7, 2024
When fetching an existing cursors, the portal already exists and the query directly starts from ExecutorRun without going through planner, post_parse or ExecutorStart. Since top spans were only initialised within those 3 hooks, cursor fetch wouldn't have a matching top span. This commit fixes the issue by creating the top span in ExecutorRun if it doesn't exist. Fixes #10
bonnefoa
added a commit
that referenced
this issue
May 7, 2024
When fetching an existing cursors, the portal already exists and the query directly starts from ExecutorRun without going through planner, post_parse or ExecutorStart. Since top spans were only initialised within those 3 hooks, cursor fetch wouldn't have a matching top span. This commit fixes the issue by creating the top span in ExecutorRun if it doesn't exist. Fixes #10
bonnefoa
added a commit
that referenced
this issue
May 7, 2024
When fetching an existing cursors, the portal already exists and the query directly starts from ExecutorRun without going through planner, post_parse or ExecutorStart. Since top spans were only initialised within those 3 hooks, cursor fetch wouldn't have a matching top span. This commit fixes the issue by creating the top span in ExecutorRun if it doesn't exist. Fixes #10
Thanks for the fix! This still fails:
|
bonnefoa
added a commit
that referenced
this issue
May 7, 2024
Closing a cursor will directly call ExecutorFinish. We need to create the top span for those cases. Also, as ExecutorEnd will be called, we will try to generate spans from planstate. However, traced planstates won't be available and representing planstate spans for cursor execution doesn't fit our current model. To fix this, we disable full query instrumentation for cursors. Fixes #10
bonnefoa
added a commit
that referenced
this issue
May 7, 2024
Closing a cursor will directly call ExecutorFinish. We need to create the top span for those cases. Also, as ExecutorEnd will be called, we will try to generate spans from planstate. However, traced planstates won't be available and representing planstate spans for cursor execution doesn't fit our current model. To fix this, we disable full query instrumentation for cursors. Fixes #10
Thanks for the report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: