Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go module file #89

Closed
nezorflame opened this issue Jan 26, 2021 · 2 comments · Fixed by #94
Closed

Add Go module file #89

nezorflame opened this issue Jan 26, 2021 · 2 comments · Fixed by #94

Comments

@nezorflame
Copy link

nezorflame commented Jan 26, 2021

In order for others to use the only currently supported vendor solution aka Go modules, this project needs a go.mod file.

This would also help with confusion some people have over the import name (DataDog vs datadog) - since the module file will contain the package name, it'll be the only proper import path after the module file gets merged.

Which one it should have is probably up for discussion (or as the author decides).

@nezorflame
Copy link
Author

@Viq111 thanks!

@Viq111
Copy link
Collaborator

Viq111 commented Feb 11, 2021

Sorry for the delay!
We were looking at #91 which is a release blocker.
As soon as it's merged (hopefully soon, just need to be able to consistently reproduce in CI tests), I'll cut a new release. I would recommend waiting for that PR to be merged first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants