Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to differentiate masculine and feminine names #999

Closed
selbiselbi opened this issue Oct 25, 2023 · 4 comments · Fixed by #1003
Closed

Being able to differentiate masculine and feminine names #999

selbiselbi opened this issue Oct 25, 2023 · 4 comments · Fixed by #1003
Labels
enhancement New feature or request

Comments

@selbiselbi
Copy link

Currently, when generating first names, the generator does not differentiate between male and female names (I'm thinking about french names, but I guess it's applicable to every country). Do you think it would be possible to implement this feature?

I could try to implement this (not sure how though for the moment).

@kingthorin kingthorin added the enhancement New feature or request label Oct 25, 2023
@kingthorin
Copy link
Collaborator

I'm not against the idea. I would not want to be the one for any given locale to try to determine which are which.

There are also a ton names that are unisex. Ex: Morgan, Darcy, Brett, etc.

There is also definitely a non-trivial amount of the population that would argue that attributing names to M/F genders is insufficient or somehow wrong.

@selbiselbi
Copy link
Author

Yeah I think those are questions that should be asked indeed. I might go with a custom solution in my code, not necessarily in this library.

It'll always be too difficult I think for people to agree to such things, and I may have rushed a bit on this subject.

Also, this lib is about generating random (real-looking) datas, not precises one. So I think my proposition is answered already.

@bodiam
Copy link
Contributor

bodiam commented Oct 25, 2023

I thought that some locales already have the concept of male and female names. I'm not sure we expose it as a property, but I wouldn't mind a PR which does this.

@bodiam
Copy link
Contributor

bodiam commented Oct 27, 2023

@selbiselbi I've implemented this change, if you can try out 2.0.3-SNAPSHOT, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants