ext_smtp.py TLS without SSL

[TomFreudenberg]

The activation for TLS is only possible on SSL connection.

That is not necessary nor that all services have enabled SSL.

cement/cement/ext/ext_smtp.py

Lines 112 to 114 in ea32057

	if is_true(params['tls']):
	LOG.debug("%s : initiating tls" % self._meta.label)
	server.starttls()

The TLS starttls command should be possible for non-SSL connections as well to make sure that the message channel is encrypted.

Would you like me to send in a PR for that?

Best regards
Tom

[TomFreudenberg]

The code

cement/cement/ext/ext_smtp.py

Lines 108 to 119 in ea32057

	if is_true(params['ssl']):
	server = smtplib.SMTP_SSL(params['host'], params['port'],
	params['timeout'])
	LOG.debug("%s : initiating ssl" % self._meta.label)
	if is_true(params['tls']):
	LOG.debug("%s : initiating tls" % self._meta.label)
	server.starttls()
	else:
	server = smtplib.SMTP(params['host'], params['port'],
	params['timeout'])

should be:

        if is_true(params['ssl']):
            server = smtplib.SMTP_SSL(params['host'], params['port'],
                                      params['timeout'])
            LOG.debug("%s : initiating ssl" % self._meta.label)

        else:
            server = smtplib.SMTP(params['host'], params['port'],
                                  params['timeout'])

        if is_true(params['tls']):
            LOG.debug("%s : initiating tls" % self._meta.label)
            server.starttls()

[derks]

Resolved in main, will be released with stable/3.0.10.