Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext_smtp.py sends empty (wrong) email addresses in server dialog #668

Closed
TomFreudenberg opened this issue Jan 17, 2024 · 1 comment
Closed
Assignees
Milestone

Comments

@TomFreudenberg
Copy link
Contributor

The current code will send empty addresses as RCPT TO: dialog <> which cause errors e.g. on mailersend service.

msg['Cc'] = ', '.join(params['cc'])
msg['Bcc'] = ', '.join(params['bcc'])

Code should be:

        if params['cc']:
            msg['Cc'] = ', '.join(params['cc'])
        if params['bcc']:
            msg['Bcc'] = ', '.join(params['bcc'])

If you like I can make a PR for both tickets

Cheers
Tom

@derks
Copy link
Member

derks commented Feb 29, 2024

Resolved in main, will be released with stable/3.0.10.

@derks derks closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants