Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Bump prost from 0.7.0 to 0.8.0 #1027

Closed
BohuTANG opened this issue Jul 11, 2021 · 4 comments
Closed

[deps] Bump prost from 0.7.0 to 0.8.0 #1027

BohuTANG opened this issue Jul 11, 2021 · 4 comments

Comments

@BohuTANG
Copy link
Member

BohuTANG commented Jul 11, 2021

Summary

audit vulnerable: https://rustsec.org/advisories/RUSTSEC-2021-0073

Bump prost from 0.7.0 to 0.8.0 ABI broken, need to fix: #1022

@BohuTANG
Copy link
Member Author

I have disabled Pull Request Security Audit action: https://github.com/datafuselabs/datafuse/actions/workflows/pr-audit.yml
It will enabled again when we fix it.

@PsiACE
Copy link
Member

PsiACE commented Jul 18, 2021

Related PR:

Possible partial follow-up work:

  • May need redesign auth service in common/flights/src/store_client.rs (FYI, https://github.com/etcdv3/etcd-client/pull/21/files)
  • Observe the following tests
    • api::rpc::flight_service_test::test_do_append
    • api::rpc::flight_service_test::test_flight_create_database
    • api::rpc::flight_service_test::test_flight_create_get_table
    • api::rpc::flight_service_test::test_flight_generic_kv
    • api::rpc::flight_service_test::test_scan_partition

@BohuTANG
Copy link
Member Author

arrow-rs upstream: apache/arrow-rs#561

@BohuTANG
Copy link
Member Author

Related PR:

Possible partial follow-up work:

  • May need redesign auth service in common/flights/src/store_client.rs (FYI, https://github.com/etcdv3/etcd-client/pull/21/files)

  • Observe the following tests

    • api::rpc::flight_service_test::test_do_append
    • api::rpc::flight_service_test::test_flight_create_database
    • api::rpc::flight_service_test::test_flight_create_get_table
    • api::rpc::flight_service_test::test_flight_generic_kv
    • api::rpc::flight_service_test::test_scan_partition

Really cool, the porst vulnerabilities block the deps upgrade, such as tonic and others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants