Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance in functions working with String #3259

Closed
sundy-li opened this issue Dec 6, 2021 · 2 comments · Fixed by #3288
Closed

Improve performance in functions working with String #3259

sundy-li opened this issue Dec 6, 2021 · 2 comments · Fixed by #3288
Labels
A-query Area: databend query C-improvement Category: improvement

Comments

@sundy-li
Copy link
Member

sundy-li commented Dec 6, 2021 •
edited
Loading

Summary

Description of this feature.
Most functions working with String are not optimized well.

  1. Unnecessary Extra copy inside the iteration loop.
  2. Validity checks which break CPU branch prediction.

cc @mshauneu may be interested in this.

Refer :

jorgecarleitao/arrow2#651
jorgecarleitao/arrow2#646
@sundy-li sundy-li added A-query Area: databend query C-improvement Category: improvement labels Dec 6, 2021
@Veeupup
Copy link
Collaborator

Veeupup commented Dec 6, 2021

maybe we should add benches for common/functions ? so we can bench functions that concerns.

@BohuTANG
Copy link
Member

BohuTANG commented Dec 6, 2021

maybe we should add benches for common/functions ? so we can bench functions that concerns.

+1
We plan to introduce a new benchmark in #3084

If you are interested in it, let's do it.

@Veeupup Veeupup mentioned this issue Dec 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-query Area: databend query C-improvement Category: improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[string performence improvement] Veeupup/databend
3 participants
@BohuTANG @sundy-li @Veeupup