Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alter table #3461

Closed
wubx opened this issue Dec 14, 2021 · 5 comments
Closed

Add alter table #3461

wubx opened this issue Dec 14, 2021 · 5 comments
Assignees
Labels
A-query Area: databend query A-storage Area: databend storage C-feature Category: feature

Comments

@wubx
Copy link
Member

wubx commented Dec 14, 2021

Summary

some time not think ok , there maybe design wrong column type or lose column

We need add alter table add column or remove column , change column.

@wubx wubx added the C-feature Category: feature label Dec 14, 2021
@dantengsky
Copy link
Member

@sundy-li is it reasonable/proper to introduce another filed, let say, column_id to DataField?

@sundy-li
Copy link
Member

What does column_id mean? Is it something like table_id to identify unique column ?

@dantengsky
Copy link
Member

What does column_id mean? Is it something like table_id to identify unique column ?

yes, all the columns are uniquely identified by column_id, and

  • column_id never changes, if the column is renamed.
  • column_id increased monotonically, if a new column was added.
  • column_id will not be re-used, if a column is dropped

@dantengsky
Copy link
Member

oh, forget to say,

columns are uniquely identified by column_id in the scope of a given table

columns of different tables, may have same column id

@dantengsky
Copy link
Member

@sundy-li let me try to address this issue without touching the DataField

@dantengsky dantengsky self-assigned this Dec 15, 2021
@BohuTANG BohuTANG added A-query Area: databend query A-storage Area: databend storage labels Mar 29, 2022
@Xuanwo Xuanwo added this to the v0.8 milestone May 20, 2022
@Xuanwo Xuanwo added A-storage Area: databend storage and removed A-storage Area: databend storage labels May 20, 2022
@Xuanwo Xuanwo removed this from the v0.8 milestone Aug 15, 2022
@zhyass zhyass self-assigned this Sep 6, 2022
@lichuang lichuang self-assigned this Dec 14, 2022
@BohuTANG BohuTANG assigned lichuang and unassigned lichuang, dantengsky and zhyass Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query A-storage Area: databend storage C-feature Category: feature
Projects
Status: 📦 Done
Development

Successfully merging a pull request may close this issue.

7 participants