Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add PRESIGN support #6215

Closed
9 tasks done
Xuanwo opened this issue Jun 24, 2022 · 5 comments · Fixed by #6529
Closed
9 tasks done

Feature: Add PRESIGN support #6215

Xuanwo opened this issue Jun 24, 2022 · 5 comments · Fixed by #6529
Labels
A-storage Area: databend storage C-feature Category: feature

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Jun 24, 2022 •
edited by BohuTANG

TODO List

reqsign

OpenDAL

Databend

Notes

  • We will implement this feature for s3 first.

Reference
@Xuanwo Xuanwo added the C-feature Category: feature label Jun 24, 2022
@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 24, 2022

Depends on opendal: apache/opendal#394

@BohuTANG BohuTANG added the A-storage Area: databend storage label Jun 24, 2022
@BohuTANG
Copy link
Member

Btw, what is the GET_STAGE_LOCATION used for?

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 24, 2022

Btw, what is the GET_STAGE_LOCATION used for?

I don't know either. Seems this SQL function can be used in other SQL queries.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 29, 2022

Progress report:

  • Implemented query sign for aws s3 in reqsign
  • Implemented accessor_capabilities support in opendal

Next step:

  • Implement presign support in opendal

@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 4, 2022

All works at the opendal's side have been done: apache/opendal#417

We can start adding this feature to the databend!

@Xuanwo Xuanwo changed the title Feature: Add GET_PRESIGNED_URL support Feature: Add PRESIGN support Jul 6, 2022
This was referenced Jul 6, 2022
Merged
Merged
@PsiACE PsiACE mentioned this issue Jul 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-storage Area: databend storage C-feature Category: feature
Projects
Databend Storage Layer
Status: 📦 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement presign support Xuanwo/databend
2 participants
@BohuTANG @Xuanwo