Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce deserialize times while reading from fuse table. #7546

Closed
RinChanNOWWW opened this issue Sep 9, 2022 · 1 comment · Fixed by #7551
Closed

Reduce deserialize times while reading from fuse table. #7546

RinChanNOWWW opened this issue Sep 9, 2022 · 1 comment · Fixed by #7551
Assignees
@RinChanNOWWW
Labels
C-improvement Category: improvement

Comments

@RinChanNOWWW
Copy link
Member

Summary

In the prewhere implementation of #7340, we first deserialize prewhere columns (prewhere filter), and then deserialize all columns (final deserialization).

As a result, we deserialize prewhere columns twice, and this is unnecessary. I think it's better to deserialize prewhere columns and remain columns once, and merge them.
@RinChanNOWWW RinChanNOWWW added the C-improvement Category: improvement label Sep 9, 2022
@RinChanNOWWW RinChanNOWWW self-assigned this Sep 9, 2022
@RinChanNOWWW
Copy link
Member Author

cc @sundy-li

@RinChanNOWWW RinChanNOWWW mentioned this issue Sep 9, 2022
Merged
@mergify mergify bot closed this as completed in #7551 Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RinChanNOWWW RinChanNOWWW

Labels
C-improvement Category: improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(query): reduce deserialization times of prewhere.
1 participant
@RinChanNOWWW