Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plan] Add set_description for plan and actions #790

Closed
BohuTANG opened this issue Jun 9, 2021 · 4 comments
Closed

[plan] Add set_description for plan and actions #790

BohuTANG opened this issue Jun 9, 2021 · 4 comments
Assignees
@jyz0309
Labels
C-feature Category: feature C-improvement Category: improvement C-observability Category: Profiling, tracing community-take

Comments

@BohuTANG
Copy link
Member

BohuTANG commented Jun 9, 2021

Summary

Like ClickHouse does, shows each step or action in more detail for the explain or log dump.

Example:
image

https://github.com/ClickHouse/ClickHouse/blob/7e610b54771e15cb2e701165d2e2c8b315a7da42/src/Interpreters/InterpreterSelectQuery.cpp#L2446-L2448
@BohuTANG BohuTANG added C-feature Category: feature C-improvement Category: improvement labels Jun 9, 2021
@BohuTANG BohuTANG changed the title [planners] Add set_description for plan and actions [plan] Add set_description for plan and actions Jun 9, 2021
@BohuTANG BohuTANG added the C-observability Category: Profiling, tracing label Jun 10, 2021
@jyz0309
Copy link
Contributor

jyz0309 commented Sep 14, 2021

/assignme

@jyz0309
Copy link
Contributor

jyz0309 commented Sep 16, 2021

I have no idea about adding set_description for planner. Do I just need to add it in planBuider?

@BohuTANG
Copy link
Member Author

Hi @jyz0309
I think this issue is a low priority and does not appear to be used at the moment.
It would be more appropriate to start this task when the planner refactoring #1217 is complete.

@Xuanwo
Copy link
Member

Xuanwo commented Jul 2, 2022

Closing for this task is not useful.

@Xuanwo Xuanwo closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jyz0309 jyz0309

Labels
C-feature Category: feature C-improvement Category: improvement C-observability Category: Profiling, tracing community-take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@BohuTANG @sundy-li @Xuanwo @jyz0309 @databend-bot