New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[store] refactor: rename store to dfs #1979

Merged

ariesdevil merged 1 commit into datafuselabs:master from drmingdrmer:mv-store

Sep 26, 2021

Member

drmingdrmer commented Sep 26, 2021 •

edited

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

[store] refactor: rename store to dfs

Changelog

Improvement

Related Issues


          [store] refactor: rename store to dfs

61e5045

drmingdrmer added the databend-store label

Member

databend-bot commented Sep 26, 2021

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

drmingdrmer requested review from ariesdevil and dantengsky

September 26, 2021 15:20

databend-bot added the pr-improvement label

Member

databend-bot commented Sep 26, 2021

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

drmingdrmer removed request for ariesdevil and dantengsky

September 26, 2021 15:22

codecov-commenter commented Sep 26, 2021 •

edited

Codecov Report

Merging #1979 (61e5045) into master (c6823b9) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1979   +/-   ##
======================================
- Coverage      68%     68%   -1%     
======================================
  Files         639     639           
  Lines       36180   36180           
======================================
- Hits        24912   24910    -2     
- Misses      11268   11270    +2

Impacted Files	Coverage Δ
cli/src/cmds/status.rs	`87% <ø> (ø)`
cli/src/cmds/status_test.rs	`91% <ø> (ø)`
common/sled-store/src/kv.rs	`50% <ø> (ø)`
common/store-api-sdk/src/store_client.rs	`80% <ø> (ø)`
dfs/src/api/http/v1/config.rs	`100% <ø> (ø)`
dfs/src/api/http/v1/config_test.rs	`93% <ø> (ø)`
dfs/src/api/http/v1/health.rs	`83% <ø> (ø)`
dfs/src/api/http/v1/health_test.rs	`91% <ø> (ø)`
dfs/src/api/http_service.rs	`14% <ø> (ø)`
dfs/src/api/http_service_test.rs	`64% <ø> (ø)`
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6823b9...61e5045. Read the comment docs.

drmingdrmer requested review from ZhiHanZ, ariesdevil, BohuTANG and dantengsky

September 26, 2021 18:00

drmingdrmer marked this pull request as ready for review

September 26, 2021 18:00

Member

ariesdevil commented Sep 26, 2021

/LGTM

databend-bot approved these changes

View reviewed changes

Member

databend-bot commented Sep 26, 2021

Approved! Thank you for the PR @drmingdrmer

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

11 similar comments

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

26 similar comments

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

ariesdevil merged commit 5dac9dc into datafuselabs:master

Member

databend-bot commented Sep 26, 2021

CI Passed
Reviewer Approved
Let's Merge

drmingdrmer deleted the mv-store branch

September 27, 2021 05:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

databend-bot databend-bot approved these changes

ZhiHanZ Awaiting requested review from ZhiHanZ

ariesdevil Awaiting requested review from ariesdevil

BohuTANG Awaiting requested review from BohuTANG

dantengsky Awaiting requested review from dantengsky