fix substring function #636
Conversation
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
======================================
Coverage 80% 80%
======================================
Files 286 284 -2
Lines 13782 13848 +66
======================================
+ Hits 11094 11150 +56
- Misses 2688 2698 +10
Continue to review full report at Codecov.
|
common/datavalues/src/data_type.rs
Outdated
| @@ -259,6 +259,22 @@ pub fn numerical_arithmetic_coercion( | |||
| } | |||
| } | |||
|
|
|||
| #[inline] | |||
| pub fn numerical_singed_coercion(val_type: &DataType) -> Result<DataType> { | |||
There was a problem hiding this comment.
numerical_signed_coercion convert unsigned data type to signed
|
Stateless tests are not passed. Please take look at: https://github.com/datafuselabs/datafuse/blob/master/scripts/ci/ci-stateless-tests-standalone.sh |
| arrow_primitive_array_negate!(&value_array, &coercion_type) | ||
| } | ||
| // @todo support other unary operation | ||
| _ => Result::Err(ErrorCodes::BadArguments("Unsupported unary operation")) |
There was a problem hiding this comment.
It's better to hint what's the op is in the error:
ErrorCodes::BadArguments(format!( "Unsupported unary operation: {:?} as argument", op))
I have fixed the test. PTAL @sundy-li |
|
CI Passed |
Summary
add
DataArrayArithmetic::data_array_unary_arithmetic_opto support unary operation.add some test case from substring
Changelog
Related Issues
Fixes #573
Test Plan
Unit Tests
Stateless Tests