Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colour coding is not switched off after it was saved to layout and analysis was re-loaded #1071

Closed
JianmeiFan opened this issue Sep 26, 2022 · 10 comments
Assignees
Labels
NX NIBR-related
Projects

Comments

@JianmeiFan
Copy link
Collaborator

Steps to reproduce:
open analysis
enable colour coding on a column
save layout
re-load analysis
try to switch off the colour coding on the column
Actual result: colour coding is not switched off. There is an inconsistency between column (coloured) and colour coding dialog (colouring is shown as 'off').
Issue is reproduced for linear, conditional and categorical colouring.
Grid Color coding is under Auto
image-2021-06-17-14-22-41-851

@skalkin skalkin added the NX NIBR-related label Sep 27, 2022
@skalkin skalkin added this to Needs triage in Core via automation Sep 27, 2022
@onuf
Copy link
Contributor

onuf commented Oct 11, 2022

Fixed in 1.7.1

@onuf onuf closed this as completed Oct 11, 2022
Core automation moved this from Needs triage to Closed Oct 11, 2022
@onuf
Copy link
Contributor

onuf commented Oct 11, 2022

@JianmeiFan the color is propagated before/after layout application:
image
image

@katerina-stepanova
Copy link
Collaborator

katerina-stepanova commented Nov 1, 2022

v1.8.2
Colour coding menu and dialog is not properly initialised after re-applying layout.

  1. Apply some colour coding (linear, conditional or categorical)
  2. Save layout
  3. Re-apply layout
  4. Check column's context menu and colour coding dialog

Expected: colour coding is applied, context menu and colour coding dialog are consistent with the column.
Actual: colour coding is applied, but is shown as 'off' in the context menu and colour coding dialog:
image
When colour coding dialog is opened, colour coding is removed from the column.
Possible reason: only '.color-coding-' tag is set on the column, '.color-coding-type' tag is missing.

Core automation moved this from Closed to Needs triage Nov 1, 2022
@onuf
Copy link
Contributor

onuf commented Nov 3, 2022

@katerina-stepanova is it reproduced in native DG, or specifically in the ID app?

@katerina-stepanova
Copy link
Collaborator

@onuf Yes, it is reproduced in native DG too: apply colours > save layout > open table again > re-apply saved layout.
It applies to all types of colouring (conditional, linear, categorical), '.color-coding-type' tag is missing when saved layout is re-applied.

@skalkin
Copy link
Collaborator

skalkin commented Nov 3, 2022

This is strange, I just tested it on public.datagrok.ai, and everything seems to be in order. @onuf , it might make sense for you to meet with @katerina-stepanova to figure our what's happening

@katerina-stepanova
Copy link
Collaborator

@skalkin @onuf I've just checked it on public.datagrok.ai, it can be reproduced.
More detailed steps:

  1. Apply some colour coding (linear, conditional or categorical)
  2. Save layout
  3. Close and re-open the same table, or refresh browser page and open the same table again
  4. Re-apply saved layout
  5. Check column's context menu and colour coding dialog

@onuf
Copy link
Contributor

onuf commented Nov 4, 2022

Thanks @katerina-stepanova, I managed to reproduce it yesterday, already working on a fix for that, should be ready today

@onuf
Copy link
Contributor

onuf commented Nov 4, 2022

Fixed, waiting for deployment & testing on our dev environment

@onuf
Copy link
Contributor

onuf commented Nov 10, 2022

Fixed in 1.8.3

@onuf onuf closed this as completed Nov 10, 2022
Core automation moved this from Needs triage to Closed Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NX NIBR-related
Projects
Core
Closed
Development

No branches or pull requests

4 participants