Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold tree: colour is not inherited by child node properly #2474

Closed
katerina-stepanova opened this issue Oct 31, 2023 · 3 comments
Closed
Assignees
Labels
bug Something isn't working NX NIBR-related

Comments

@katerina-stepanova
Copy link
Collaborator

katerina-stepanova commented Oct 31, 2023

chem 1.8.3

Steps to reproduce:

  1. Open a table, e.g. SPGI
  2. Add scaffold tree
  3. Draw at least two nodes: parent and a child
  4. Enable colouring for the parent > both parent and child node have the same colour set:
image
  1. Select checkbox for the child node to filter table by this item
  2. See the structures highlighting

Expected results: structures should be highlighted by parent node's colour that was inherited by the child.
Actual results: default highlighting colour is used to highlight structures matching the child node:
image
Issue can be also reproduced for scaffold tree filter in filter panel.

@katerina-stepanova katerina-stepanova added the NX NIBR-related label Oct 31, 2023
@ahadzhanian ahadzhanian added the bug Something isn't working label Oct 31, 2023
@ahadzhanian ahadzhanian removed the bug Something isn't working label Oct 31, 2023
@Aleksashka11
Copy link
Collaborator

This is our expected behaviour.
If the structure has a parent color, only a part of it is highlighted. During filtering, we need the structure we are filtering by to be fully highlighted. Therefore, the part to which the parent color is attached is highlighted by it, and the remaining part is highlighted with the filter color as usual.
If we won't provide an additional coloring for remaining part, it will be hard for user to understand by which part he is filtering.

@ahadzhanian ahadzhanian added the bug Something isn't working label Oct 31, 2023
@ahadzhanian
Copy link
Collaborator

2274

@ahadzhanian
Copy link
Collaborator

Chem 1.8.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working NX NIBR-related
Projects
None yet
Development

No branches or pull requests

3 participants