Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Did not get a notification about new release #204

Closed
Mikanebu opened this issue Apr 13, 2018 · 2 comments
Closed

Did not get a notification about new release #204

Mikanebu opened this issue Apr 13, 2018 · 2 comments
Assignees
@anuveyatsu
Labels
Priority ★★★ Severity: Major
Milestone
Sprint - 23 Apr 2018

Comments

@Mikanebu
Copy link
Member

I did not get any warning about using old version old data-cli

How to reproduce

  • Install an older version of data-cli
  • Run any command

Expected behaviour

I should get a warning saying that I'm using old version of the CLI tool.
@Mikanebu Mikanebu added this to the Sprint - 23 Apr 2018 milestone Apr 13, 2018
@anuveyatsu anuveyatsu self-assigned this Apr 13, 2018
anuveyatsu added a commit to datopian/data-cli that referenced this issue Apr 13, 2018
@anuveyatsu
[updates][xs]: dont cache update notifier results for more than a sec…
6fb0ad0 
…ond - refs datopian/datahub-qa#204
@anuveyatsu
Copy link
Member

Should be fixed with the next release.

@AcckiyGerman
Copy link
Contributor

Before update check results was cached for 1 hour.
FIXED:
The update check results are not cashed. Update warning will be shown after each command run.

@Mikanebu @anuveyatsu I liked previous behavior (notify once in a hour) but let's wait for users feedback about this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anuveyatsu anuveyatsu

Labels
Priority ★★★ Severity: Major
Projects
None yet
Milestone
Sprint - 23 Apr 2018
Development

No branches or pull requests
3 participants
@AcckiyGerman @anuveyatsu @Mikanebu