Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social function issues introduced by the latest version of the frontend #1824

Closed
cobolbaby opened this issue Aug 27, 2020 · 3 comments
Closed
Assignees
Labels
bug Bug report

Comments

@cobolbaby
Copy link
Contributor

The latest version of the datahub-frontend will output some error messages on the console when doing web page operations.

2020-08-27 14-59-00屏幕截图

Check the error message, you'll find that the front-end seems to support some friendly social functions, but the mid-tier does not provide corresponding support. When will the related functions be released?

In addition, judging from the http requests, the front end repeatedly pushed some requests, which is obviously some potential problems.

@cobolbaby cobolbaby added the question Question label Aug 27, 2020
@cobolbaby cobolbaby changed the title Some new issues introduced by the latest version of the frontend Social function issues introduced by the latest version of the frontend Aug 27, 2020
@mars-lan mars-lan added bug Bug report and removed question Question labels Aug 27, 2020
@cptran777
Copy link
Contributor

Hey @cobolbaby , thanks for reporting this. We're aware of this un-ideal change but it shouldn't be blocking or disruptive so that's why it's currently checked in. Unfortunately, things will be a little weird on the frontend/UI while we transition into a new open source workflow after allowing it to be stale for so many months. However, we're currently working through a lot of these pain points and I think in the long run it'll be quite an exciting new development where we can constantly evolve along with the community and feedback.

Anyway, a little bit of a tangent there, we'll be working on cleaning this up as well, instead of relying on the un-ideal situation, and it'll be optional (if you want to implement support) and not mandatory + erroring out.

@cobolbaby
Copy link
Contributor Author

cobolbaby commented Sep 4, 2020

The latest commit fixes the previous one but introduces new bug:

  • Blood relationship cannot be displayed correctly

2020-09-04 11-45-54屏幕截图

2020-09-04 16-00-19屏幕截图

@cptran777
Copy link
Contributor

Hey @cobolbaby,

I think this issue is related to: #1827. Since the social function issue has been fixed and the other issue is being tracked, I'll close this issue so that we have a cleaner workflow for tracking issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

3 participants