Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glue ingested tables in lineage view shows fullname with arn #6182

Open
KulykDmytro opened this issue Oct 12, 2022 · 7 comments
Open

Glue ingested tables in lineage view shows fullname with arn #6182

KulykDmytro opened this issue Oct 12, 2022 · 7 comments
Labels
accepted An Issue that is confirmed as a bug by the DataHub Maintainers. bug Bug report ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX

Comments

@KulykDmytro
Copy link
Contributor

Describe the bug
Glue ingested tables in lineage view shows fullname with arn instead of {database_name}.{table_name} when Show Full Titles enabled

To Reproduce
Steps to reproduce the behavior:

  1. Ingest Glue table(s)
  2. open it in Lineage graph
  3. switch on Show Full Titles

Expected behavior
Full name og Glue table should be like {database_name}.{table_name}

Screenshots
image
image

@KulykDmytro KulykDmytro added the bug Bug report label Oct 12, 2022
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

@github-actions github-actions bot added the stale label Nov 12, 2022
@laulpogan laulpogan added ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX labels Dec 7, 2022
@github-actions github-actions bot removed the stale label Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Jan 8, 2023

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

@aditya-radhakrishnan
Copy link
Contributor

Hey @KulykDmytro I apologize for the delay in getting back to you. For all entities, we essentially show the full name of the entity (as represented in the urn) when that "show full title" button is toggled on. It's not clear to me how we would resolve it differently for each type of data platform (S3, Snowflake, etc), and this seems like a reasonable fallback. Given this, I think we're going to keep this part of the UI as is. I'm going to close out this issue.

Either way, I appreciate you taking the time to bring this to our attention. Thank you!

@KulykDmytro
Copy link
Contributor Author

KulykDmytro commented Oct 2, 2023

@aditya-radhakrishnan looks like glue table have very determined full name: {database}.{table} why not to use it in fullname build for this type of dataset (like it done in any other relational datasets)
is it possible to make it work like this or provide such ability in config?

@KulykDmytro
Copy link
Contributor Author

KulykDmytro commented Oct 2, 2023

occasionally i've found another one example of same (Athena table) but with catalog added in the name

  • urn:li:dataset:(urn:li:dataPlatform:athena,awsdatacatalog.core.adpool_browser_history,PROD) - ingested over dbt,
    and this shown in lineage (with full titles) as awsdatacatalog.core.adpool_browser_history
    my original ones looks like:
  • urn:li:dataset:(urn:li:dataPlatform:athena,core.adpool_browser_history,PROD) - ingested over glue,
    and shown in lineage (with full titles) as arn:aws:glue:eu-central-1:429593101123:table/core/adpool_browser_history

i beleive this is not right

@treff7es treff7es added the accepted An Issue that is confirmed as a bug by the DataHub Maintainers. label Oct 4, 2023
@treff7es
Copy link
Contributor

treff7es commented Oct 4, 2023

I think it is a valid issue, as we should be consistent in how we ingest Athena urns. Either we should have the catalog name in the urns which comes from DBT and Athena, or not have it, but it should be consistent.

@treff7es treff7es reopened this Oct 8, 2023
@KulykDmytro
Copy link
Contributor Author

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted An Issue that is confirmed as a bug by the DataHub Maintainers. bug Bug report ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

No branches or pull requests

4 participants