datahub-protobuf doesn't parse message comment correctly

[tinolyu]

Describe the bug
datahub-protobuf doesn't parse message comment correctly

To Reproduce
Steps to reproduce the behavior:

1. Using datahub-protobuf 0.9.6
2. Modify metadata-integration/java/datahub-protobuf/src/test/resources/protobuf/messageB.proto, add message OuterMessage above message MessageB and compile proto.

// Description for OuterMessage
message OuterMessage {
  MessageB messageB = 1;
}

3. Add the function getTestProtobufGraph in metadata-integration/java/datahub-protobuf/src/test/java/datahub/protobuf/TestFixtures.java and modify metadata-integration/java/datahub-protobuf/src/test/java/datahub/protobuf/visitors/dataset/DescriptionVisitorTest.java to find the root message

public static ProtobufGraph getTestProtobufGraph(String protoPackage, String filename, String m) throws IOException {
    return new ProtobufGraph(getTestProtobufFileSet(protoPackage, filename), m);
}

ProtobufGraph graph = getTestProtobufGraph("protobuf", "messageB", "protobuf.MessageB");

4. Run the test

Expected behavior
I hope to get the description of MessageB

/**
 * This contains nested types.
 *
 * Owned by TeamB
 */

But it read the description of OuterMessage.

[tinolyu]

It seems this PR removed the message check messageProto() == fileProto().getMessageType(loc.getPath(1)) in datahub.protobuf.model.ProtobufElement, and it now could not parse the message comment correctly if there are multiple messages in a proto file.

[david-leifker]

I believe this was fixed here ?

[tinolyu]

Is it in the v0.9.6.1?

I believe this was fixed here ?

[tinolyu]

I believe this was fixed here ?

It still couldn't work.

[david-leifker]

0.9.6.1 doesn't contain the fix, would be included in the next release. Will add test to verify.

[github-actions]

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

[github-actions]

This issue was closed because it has been inactive for 30 days since being marked as stale.