Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search autocomplete causing site outages #9176

Closed
timcosta opened this issue Nov 3, 2023 · 2 comments
Closed

Search autocomplete causing site outages #9176

timcosta opened this issue Nov 3, 2023 · 2 comments
Labels
bug Bug report

Comments

@timcosta
Copy link
Contributor

timcosta commented Nov 3, 2023

Describe the bug
The search bar does not debounce autocomplete requests, so every character typed results in an outgoing call to graphql and the backing search cluster.

This causes load on the search cluster to go from 5-10 tps to over a hundred when more than one person is typing at once, which takes it down temporarily and results in a near total site outage until it recovers.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the search page like https://datahub.mycompany.com/search
  2. Open network console
  3. Start typing characters
  4. See tens or hundreds of graphql requests being made, one for every character you type

Not sure if it's relevant, but our users all have a default view selected.

Expected behavior
Autocomplete should be debounced and only fire after a user hasnt entered a character for a few hundred milliseconds.

Screenshots
image

Desktop (please complete the following information):

  • OS: macos
  • Chrome
  • Version 118.0.5993.117

Additional context
This is an issue that causes total outages for us multiple times per day.

@timcosta timcosta added the bug Bug report label Nov 3, 2023
@chriscollins3456
Copy link
Collaborator

hey @timcosta here's a PR to address this issue! #9205

@timcosta
Copy link
Contributor Author

timcosta commented Nov 9, 2023

Nice, thanks for fixing this @chriscollins3456!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

3 participants