Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the rich rich.logging.RichHandler gracefully #5

Open
datajoely opened this issue Mar 7, 2022 · 0 comments
Open

Apply the rich rich.logging.RichHandler gracefully #5

datajoely opened this issue Mar 7, 2022 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@datajoely
Copy link
Owner

Description

In order to enable the rich logging handler via an external plugin we currently intercept the way that the KedroSession parses the contents of conf/base/logging.yml and ensure that the console key is updated to use the right handler.

I tried for agest to intercept the handlers after creation and change them dynamically through approaches like this but this is the only mechanism I could get to work.

Potential solutions to evaluate:

  • Work out the correct way to mutate the global logging objects so that the given log-handler is ignored without the need for monkey patching.
  • Given rich is becoming quite mature at this point I think there is a decent argument for this becoming the default handler in the core Kedro library.
@datajoely datajoely added the help wanted Extra attention is needed label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant