Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tests to self tests #28

Closed
lrnzcig opened this issue Oct 30, 2022 · 1 comment · Fixed by #29
Closed

integration tests to self tests #28

lrnzcig opened this issue Oct 30, 2022 · 1 comment · Fixed by #29
Assignees

Comments

@lrnzcig
Copy link
Collaborator

lrnzcig commented Oct 30, 2022

After PR #19 is merged, adding integration tests becomes low hanging fruit.

The test test_run_dot_tests runs the full DOT pipeline for the demo sample dataset. Adding checks to the results would make unnecessary to run the regression tests that we used in the legacy DOT repo.

Additionally, the following tests should not run the full DOT pipeline:

  • test_dbt_log_safe.py
  • test_utils.py
  • test_utils_schema_improved.py
    but only the steps that are actually under test.
@lrnzcig lrnzcig self-assigned this Oct 30, 2022
@dividor
Copy link
Collaborator

dividor commented Nov 2, 2022

Hi @lrnzcig,

Thanks so much for PR #19, it's now merged.

Go for the low-hanging fruit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants