Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Add environment variables option #194

Closed
asmacdo opened this issue Feb 7, 2023 · 2 comments
Closed

RFE: Add environment variables option #194

asmacdo opened this issue Feb 7, 2023 · 2 comments

Comments

@asmacdo
Copy link
Collaborator

asmacdo commented Feb 7, 2023

IMO, containers should usually be configured via environment variables, so it seems like
datalad containers-run should accept --env and --env-file and pass along to singularity.

Alternatively, we could also add a flag --singularity-vars "env-file=/home/here" or similar.

@yarikoptic
Copy link
Member

yeah, might be useful to allow for custom env configuration for a container. In principle that can already be possible for people by tuning their fork of this dataset and changing invocations in .datalad/config accordingly. Before bothering to improve upon that we better gain specific use cases to address.

@asmacdo
Copy link
Collaborator Author

asmacdo commented Feb 20, 2023

My only use case was experimenting. closing for now, if anyone needs this please reopen and post your use case!

@asmacdo asmacdo closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants