Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: modify dataset="^" shortcut to become dataset="^*" #1024

Closed
yarikoptic opened this issue Oct 17, 2016 · 5 comments
Closed

RFC: modify dataset="^" shortcut to become dataset="^*" #1024

yarikoptic opened this issue Oct 17, 2016 · 5 comments
Assignees

Comments

@yarikoptic
Copy link
Member

#987 made me consider:

making analogy with git, it makes me think that may be ^ is suboptimal as a shortcut. In git, we have it to point to "previous" (or 1 up) commit. So theoretically we could make it understand ^ (direct superdataset), ^^ (two super-datsets up), ^n (n is a digit) - n superdatasets up (failing if there is no that many).

But then what to choose for the ultimate super -- ^*?

It will be backward incompatible since we did release already with current understanding of ^ but imho it is a tollerable breackage especially if we decide quick (I could implement). alternatively

  • we could just use some other symbol to designate "x level up", e.g. "~" if to make git analogy, but it is somewhat bad since collides with "$HOME" (although unlikely anyone would use it that way)
  • we could maintain ^ as ultimate top super-dataset, while allowing for ^^, ^^^ and ^n to go prescribed number of supers up. But then ^1 should be used for super 1 level up and it is somewhat inconsistent

what do you think?

@bpoldrack
Copy link
Member

To me it makes sense, including ^* and the breakage it results in. I think you pointed out, why alternatives are not exactly desirable.

@yarikoptic yarikoptic self-assigned this Oct 17, 2016
@mih mih removed the conference agenda item Scheduled to be discussed in a developer meeting label Apr 6, 2018
@mih
Copy link
Member

mih commented Apr 6, 2018

This issue is officially being ignored.

@kyleam
Copy link
Contributor

kyleam commented Apr 6, 2018

So theoretically we could make it understand ^ (direct superdataset), ^^ (two super-datsets up), ^n (n is a digit) - n superdatasets up

Doesn't seem to be the core thing that this issue is about, but this confused me. Your description of ^n breaks the git parallel here. ^^ is not ^2, it's ^1^1 or ~2. I don't see how git's ^n (nth parent) could have a superdataset analog.

@mih
Copy link
Member

mih commented Jun 12, 2018

The discussion came to a conclusion. Verdict 50-50 for a move in no direction ;-)

@mih mih closed this as completed Jun 12, 2018
@yarikoptic
Copy link
Member Author

well, we are in "demand driven development". So far I frequently use save -S (which should be analog to save -d^ . I guess?) but do not care to jump specific number of super datasets up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants