Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Don't claim content size is zero without status --annex availablity #3378

Merged
merged 1 commit into from May 3, 2019

Conversation

mih
Copy link
Member

@mih mih commented May 3, 2019

Before it would say:

% datalad status --annex basic
5961 annex'd files (0.0/10.1 MB present/total size)

Now it says:

% datalad status --annex basic
5961 annex'd files (10.1 MB recorded total size)

Full output with availability check remains unchanged:

% datalad status --annex availability
5961 annex'd files (89.7 KB/10.1 MB present/total size)

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #3378 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3378      +/-   ##
==========================================
- Coverage   91.24%   91.22%   -0.03%     
==========================================
  Files         265      265              
  Lines       34452    34452              
==========================================
- Hits        31436    31429       -7     
- Misses       3016     3023       +7
Impacted Files Coverage Δ
datalad/core/local/status.py 97.91% <ø> (ø) ⬆️
datalad/downloaders/http.py 83.73% <0%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca35877...1f14011. Read the comment docs.

Before it would say:
```
% datalad status --annex basic
5961 annex'd files (0.0/10.1 MB present/total size)
```

Now it says:
```
% datalad status --annex basic
5961 annex'd files (10.1 MB recorded total size)
```

Full output with availability check remains unchanged:
```
% datalad status --annex availability
5961 annex'd files (89.7 KB/10.1 MB present/total size)
```
@kyleam kyleam merged commit 1f14011 into datalad:master May 3, 2019
kyleam added a commit that referenced this pull request May 3, 2019
Copy link
Contributor

@kyleam kyleam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(I touched up the commit message slightly before merging)

@mih mih deleted the bf-statusinfo branch May 7, 2019 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants