Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the 0.2.2 package the same as the github source? #46

Closed
ukclivecox opened this issue Apr 18, 2023 · 2 comments
Closed

Is the 0.2.2 package the same as the github source? #46

ukclivecox opened this issue Apr 18, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@ukclivecox
Copy link

When trying the create-react-app it looks like the code imported is not the same as what's in master, e.g. I get errors like:

ERROR in ./node_modules/@datalayer/jupyter-react/lib/components/console/ConsoleAdapter.js 25:26-71
export 'editorServices' (imported as 'editorServices') was not found in '@jupyterlab/codemirror' (possible exports: CodeMirrorEditor, CodeMirrorEditorFactory, CodeMirrorMimeTypeService, CodeMirrorSearchHighlighter, EditorExtensionRegistry, EditorLanguageRegistry, EditorSearchProvider, EditorThemeRegistry, ExtensionsHandler, IEditorExtensionRegistry, IEditorLanguageRegistry, IEditorThemeRegistry, StateCommands, YRange, YSyncConfig, customTheme, jupyterEditorTheme, jupyterHighlightStyle, jupyterTheme, rulers, ySync, ySyncAnnotation, ySyncFacet, ybinding)

The imported 0.2.2 code has

import { editorServices } from '@jupyterlab/codemirror';

while the code in master has

import { CodeMirrorEditorFactory, CodeMirrorMimeTypeService, EditorLanguageRegistry, EditorExtensionRegistry, ybinding } from '@jupyterlab/codemirror';
@ukclivecox ukclivecox added the bug Something isn't working label Apr 18, 2023
@echarles
Copy link
Member

Correct. I will update main branch to the latest jupyerlab beta version and cut a new release asp. Thx for the feedback.

@echarles
Copy link
Member

Closing this issue as @datalayer/jupyter-react 0.0.3 has just been released. Please reopen if this does not work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants