JSON InputStreamReader

[cgardens]

What

• Currently we read from a singer tap by using lines(). If a json object is split across multiple lines, we will not be able to parse it.

How

• Use jackson parser to parse the InputStream. It handles this cross line issue. One downside is that it throws a lot of exceptions for any non json in the InputStream (on per word). My inclination is to use this implementation instead of trying to go lower level because I think doing so will be more prone to error. Curious to hear other people's opinions on this. It's the jackson json parser that throws all of these errors. If we want to use the jackson parser then we're going to have to deal with it.

@michel-tricot - this is branch is off of your branch, but I did not hook it up since you're still changing things.

[jrhizor]

@michel-tricot

Since the Singer spec has single line messages as part of the contract ("A Tap outputs structured messages to stdout in JSON format, one message per line."), why is this necessary? Wouldn't a tap producing multi-line messages be broken?

[michel-tricot]

Can we try on a postgres database and see how a blog of text with \n would behave?

[michel-tricot]

got closed because I removed the branch you depended on.

But based on Jared's finding, let's hold-off on this