Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to extend to a new model? #223

Open
billdenney opened this issue Nov 11, 2022 · 5 comments
Open

How to extend to a new model? #223

billdenney opened this issue Nov 11, 2022 · 5 comments

Comments

@billdenney
Copy link

Related to #177

I'm looking to use extract_eq() to help with the nlmixr2 package. It typically uses nonlinear, mixed-effect models that are defined by multiple equations.

For that, I was looking at several items of how this is working and I have a few questions and thoughts:

  1. Do you have some documentation of how to implement a new model? My specific thought is that it would help to provide guidance on how to do the final wrapping of the output in multiple equations. There are probably a lot more questions that would help.
  2. When writing for nlmixr2 models, many of the arguments for extract_eq() don't apply. As part of Refectoring for Extensibility #177, have you considered having the generic as something much simpler like extract_eq <- function(model, ...) {UseMethod("extract_eq")}?
  3. Would you consider exporting the escape_tex() function? Are there other internal helper functions that may be necessary for generating high-quality outputs?
@datalorax
Copy link
Owner

datalorax commented Nov 11, 2022

Hi @billdenney, those are all really good questions. The truth is development has majorly stalled on this because I just don't really have the motivation to keep up with it anymore (switching careers has something to do with that, but general burnout is a larger factor).

I had talked with @JaySumners about even taking over as maintainer, but he is the main person that has really thought through extensibility. The short answer is it's not very extensible now, and we had hoped to make it more so, but never actually got around to it.

Sorry if that's a disappointing response, but perhaps Jay will have more context or more info for you. Also happy to talk about PRs if you'd like to take on something on your own. And yes, we could definitely export any of the functions that are currently internal if they are helpful.

@billdenney
Copy link
Author

@datalorax , sorry to hear about the burnout feeling. Are you considering transitioning the package to @JaySumners for maintenance?

I think that the package is useful. If neither of you have time for maintaining and extending it, have you considered seeing if ropensci would be interested in taking over development?

@datalorax
Copy link
Owner

That's not a bad idea. I'm not sure I'm ready to do that yet, but it's definitely worth considering.

@billdenney
Copy link
Author

I wasn't intending it to be a push-- it is intended as a brainstorm. (Tone is hard by both email and github issues. 😄 )

@datalorax
Copy link
Owner

Yeah no worries, I didn't intend it as pushing. I genuinely appreciate the thought!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants