Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on Newtonsoft.Json #125

Open
beppemarazzi opened this issue Nov 2, 2023 · 3 comments
Open

Dependency on Newtonsoft.Json #125

beppemarazzi opened this issue Nov 2, 2023 · 3 comments

Comments

@beppemarazzi
Copy link

Do you plan to remove it in favor of System.Text.Json?

I've tried to do this and i got a (working?) result in a couple of hours... if it's appreciated and/or if you want ro review it i could do a PR ...

Doing this work, while doing some tests with the SeqTail sample) I've also found a dependency to Newtonsoft coming from Serilog.Formatting.Compact.Reader... so I substituted it also in that project... (i've also seen serilog/serilog-formatting-compact-reader#22 ). In this case there are a lot of test and all them are passing. So i could make a PR also for this: let me know...

@nblumhardt
Copy link
Member

Hi Giuseppe! Thanks for dropping us a line; this is on our radar - I am not 100% sure of all the implications, so we may not necessarily be able to merge straight away, but a PR would be welcome and we will definitely dig into it 👍

@brettcaswell
Copy link

interesting, what is the merit to changing the dependency? is it to support AOT compilation?

@wjrogers
Copy link

wjrogers commented Jun 4, 2024

interesting, what is the merit to changing the dependency? is it to support AOT compilation?

I would like to see Seq.Api switch to System.Text.Json because it supports source generation, which improves startup time and makes AOT and trimming possible, both of which would be great for CLI applications that interact with the Seq API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants