New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm.read_smi()
copies a file to an already existing location
#150
Comments
Thanks. Using In general, I don't recommend using this kind of reader/saver and instead use the CSV reader/saver which should work with any |
I'm not sure I understand. You're saying |
Yes. There is nothing specific to .smi. It's just a csv-like format. |
Does Datamol implement these read functions separately? Seems like 'read_smi()' should then just be a light wrapper of 'read_csv()'? |
Yes I remember hesitating doing that at the very beginning of datamol but I prefer to stick to rdkit here in case the rdkit function is modified. If a user use |
Thanks for reporting the bug @cwognum ! |
When I try to load a remote
.smi
file using Datamol, I run into the following exception:Seems like this function is not up-to-date with recent changes in the
dm.utils.fs
module? Seems to me likeactive_path
should be set differently to a non-existing file.The text was updated successfully, but these errors were encountered: