You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Logic of add_cells() and required_imports() is tightly coupled. E.g. see 9e8f50f where self.subsections_to_show_with_low_verbosity is used within both the methods. This kind of coupling introduces risk of bugs that the methods are not in sync and some imports are omitted (such as the linked PR is fixing).
I propose to merge the logic of the two methods. I am not sure how though. Maybe add_cells() can add both cells as well as imports that are required for the cells to execute successfully. required_imports() would then collect theses imports (from e.g. self._cell_imports()and potentially add some more (e.g. fromsuper`).
The text was updated successfully, but these errors were encountered:
Logic of
add_cells()
andrequired_imports()
is tightly coupled. E.g. see 9e8f50f whereself.subsections_to_show_with_low_verbosity
is used within both the methods. This kind of coupling introduces risk of bugs that the methods are not in sync and some imports are omitted (such as the linked PR is fixing).I propose to merge the logic of the two methods. I am not sure how though. Maybe
add_cells()
can add both cells as well as imports that are required for the cells to execute successfully.required_imports()
would then collect theses imports (from e.g. self._cell_imports()and potentially add some more (e.g. from
super`).The text was updated successfully, but these errors were encountered: