Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alow to configure shield-oauth inside a module #104

Open
nicojmb opened this issue Apr 6, 2024 · 3 comments
Open

Alow to configure shield-oauth inside a module #104

nicojmb opened this issue Apr 6, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nicojmb
Copy link

nicojmb commented Apr 6, 2024

Hello,

In all my ci4 projects I try not to use the "app" folder, what I do is create a "modules" folder and then one for the module in question.

In this case, I have a module called "Auth", which is located in "./modules/Auth/" and there I have the Shield customizations and it works perfect.

I have also tried to put the Shield OAuth customizations, but I see that it does not work, looking at the code I see that it looks for the files within app/Config.

Is it possible to use Shield OAuth within a module?

Example of my folder esctructure:

image

@datamweb
Copy link
Owner

datamweb commented Apr 7, 2024

Hey @nicojmb

I have also tried to put the Shield OAuth customizations,

I don't understand what you mean by Shield OAuth customizations?

Is it possible to use Shield OAuth within a module?

Do you mean custom drivers?

@nicojmb
Copy link
Author

nicojmb commented Apr 7, 2024

Hey @nicojmb

I have also tried to put the Shield OAuth customizations,

I don't understand what you mean by Shield OAuth customizations?

Is it possible to use Shield OAuth within a module?

Do you mean custom drivers?

First, sorry for my bad english :(.

if you see in my screenshot:
image

The files:

  • Config/ShieldOAuthConfig.php
  • Libraries/ShieldOAuth/MicrosoftOAuth.php

Are located in "./modules/Auth" directory, the problem is that in this location do not work, only work if a put in "App" directory.

@datamweb datamweb added enhancement New feature or request good first issue Good for newcomers labels Apr 7, 2024
@datamweb
Copy link
Owner

datamweb commented Apr 7, 2024

Thanks, this is not possible at the moment. We need changes in the code.
I don't want to make any promises, but I might make the changes in my free time..
Or sending PR in this regard is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants