In federated env. LDAPMetaDataListener raises an exception about IdentityType.DATASTORE for the classes in another RDBMS data store

[rezarahimi]

I have a federated environment which contains multiple RDBMS and a LDAP data stores, when I want to load the application I got the InvalidClassMetaDataException for the classes which belong to another RDBMS store.

[andyjefferson]

All issues need testcases so that they are reproducible. The only exception to that is where people are going to develop fixes themselves, that don't break other features

[rezarahimi]

I have commented it with following patch for my self because I care my self that do not use IdentityType.DATASTORE for my PersistenceCapable LDAP classes:

--- a/src/main/java/org/datanucleus/store/ldap/LDAPMetaDataListener.java
+++ b/src/main/java/org/datanucleus/store/ldap/LDAPMetaDataListener.java
@@ -33,10 +33,10 @@ public class LDAPMetaDataListener implements MetaDataListener
      */
     public void loaded(AbstractClassMetaData cmd)
     {
-        if (cmd.getIdentityType() == IdentityType.DATASTORE && !cmd.isEmbeddedOnly())
+ /*       if (cmd.getIdentityType() == IdentityType.DATASTORE && !cmd.isEmbeddedOnly())
         {
             // Datastore id not supported
             throw new InvalidClassMetaDataException("LDAP.DatastoreID", cmd.getFullClassName());
-        }
+        }*/
     }

and my test environment is inside Apache ISIS and I don't know when I can create a suitable separate test case for it(I will try to do it but I am not sure when) but it is clear that checking all the AbstractClassMetaData classes with identityType of IdentityType.DATASTORE without any guards includes all classes of all stores and the RDBMS ones too.
I had to fix some other bugs in datanucleus-core and datanucleus-rdbms too for running my Apache ISIS application which need really a test case.

[andyjefferson]

Thanks, but clearly commenting out functionality is not an option.
What would be an option is for you to provide a persistence property that is applied at the store level (StoreManager) that disables metadata checks (default to have them enabled). So then you can disable via a persistence property for particular stores used by DataFederation.