Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to latest 3.1.3 release of neo4j libraries #26

Closed
dhakehurst opened this issue Apr 6, 2017 · 4 comments
Closed

Move to latest 3.1.3 release of neo4j libraries #26

dhakehurst opened this issue Apr 6, 2017 · 4 comments

Comments

@dhakehurst
Copy link

the latest release of neo4j is 3.1.3.

if I use the datanucleus conector in my code, I cannot use the neo4j tools to view the same data, because datanucleus-neo4j uses an older (incompatible) version of the libraries.

  1. create DB via datanucleus-neo4j
  2. view data using neo4j 3.1.3
  3. attempt to reconnect using datanucleus-neo4j
@andyjefferson
Copy link
Member

andyjefferson commented Apr 7, 2017

If I run any test case manually specify the maven dependency

<dependency>
    <groupId>org.neo4j</groupId>
    <artifactId>neo4j</artifactId>
    <version>3.1.3</version>
</dependency>

they all run fine with current DN codebase. Also a plain rebuild against 3.1.3 requires zero changes to DN code. Consequently I can't see the need to do anything here. Did you simply not specify the neo4j dependency and rely on Maven dependency resolution to pull in 3.0.0 ? in which case specify 3.1.3 in your POM

@dhakehurst
Copy link
Author

no I did not specify the neo4j version
(and I am using gradle not maven)

but seeing as this library has an explicit dependency on neo4j....why can I not rely on the transitive dependencies.

and the version of neo4j is explicitly set in this librabry, via a property. If we are expected to add our own dependency to a different version of neo4j, then the maven dependency should be marked as "provided" scope.

@andyjefferson
Copy link
Member

No interest in making it provided. The way we have it, if a user wants to not specify it they get 3.0.0, and if they want to specify it then they get the version they ask for. Further than that people can easily contribute PULL REQUESTs

@andyjefferson
Copy link
Member

User can easily use 3.x later versions by specifying it, and by default getting what the DN plugin is built against. Hence nothing to do here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants