Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in documentation rst files. #90

Merged
merged 3 commits into from Oct 18, 2021

Conversation

spazm
Copy link
Contributor

@spazm spazm commented Oct 12, 2021

Fixes the current warnings in docs/**/*rst files

  • The "inline strong" and "Bullet list" warnings both affect the rendered output.
  • The "Title underline" warning does not affect the rendered output.
docs/components/ory/technical.rst:23: WARNING: Bullet list ends without a blank line; unexpected unindent.
docs/components/ory/usage.rst:14: WARNING: Inline strong start-string without end-string.
docs/components/ory/usage.rst:33: WARNING: Inline strong start-string without end-string.
docs/components/ory/usage.rst:56: WARNING: Title underline too short.

Identities and Providers
~~~~~~~~~~~~~~~~~~~~
docs/components/ory/usage.rst:56: WARNING: Title underline too short.

Identities and Providers
~~~~~~~~~~~~~~~~~~~~

Bolding was incorrectly written with a single `*` and
was interpretted as a single item list with trailing `*`.

fixes:

    ```
    docs/components/ory/technical.rst:23:
    WARNING: Bullet list ends without a blank line; unexpected unindent.
    ```
Removes the leading space from the bold/strong
end tag because it was binding to the :: code
block tag and confusing the parser.

    ```
    docs/components/ory/usage.rst:14:
    WARNING: Inline strong start-string without end-string.
    docs/components/ory/usage.rst:33:
    WARNING: Inline strong start-string without end-string.
    ```
Title underline must be at least as long as the text it is underlining.
This is only a warning condition and does not affect the rendered html.

Fixes:

    ```
    docs/components/ory/usage.rst:56:
    WARNING: Title underline too short.
    ```
@spazm spazm changed the title Feature/rst clean up Fix warnings in documentation rst files. Oct 12, 2021
@spazm
Copy link
Contributor Author

spazm commented Oct 12, 2021

If this PR is useful, I'd appreciate if you could add a label of "hacktoberfest-accepted".

Copy link
Contributor

@tvinagre tvinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bernardolk bernardolk merged commit 2f340a0 into datarevenue-berlin:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants