Log-verbosity #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add func that allows to switch to debug loglevel mode if verbose mode is requested
Codecov Report
@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 94.52% 95.26% +0.73%
==========================================
Files 14 14
Lines 585 591 +6
==========================================
+ Hits 553 563 +10
+ Misses 32 28 -4
Continue to review full report at Codecov.
|
|
Thanks for the PR. I like the changes! I left some minor pedantic requests 😊. |
murilo-cunha
requested changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package uses logging functionalty but introduces a "verbose" concept where loglevel INFO suddendly becomes more verbose. This is a small PR that switches log level level to DEBUG when
--verboseflag is passed by the user.