Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the location of LICENSE file #57

Merged
merged 1 commit into from Nov 8, 2022

Conversation

frenzymadness
Copy link
Contributor

LICENSE is included automatically by poetry and it's installed
into .dist-info directory. This manual include caused the file to
be installed also into lib/python3.11/site-packages next
to the main databooks package.

LICENSE is included automatically by poetry and it's installed
into .dist-info directory. This manual include caused the file to
be installed also into lib/python3.11/site-packages next
to the main databooks package.
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #57 (2df9e2e) into main (a0cb049) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          26       26           
  Lines        1433     1433           
=======================================
  Hits         1381     1381           
  Misses         52       52           

@frenzymadness
Copy link
Contributor Author

I've tested this manually but it would be good if someone else can confirm my words.

@murilo-cunha murilo-cunha self-requested a review November 8, 2022 14:41
@murilo-cunha
Copy link
Member

I'll check this out as well but what are the practical implications of this?

I.e.: Why do we prefer having the LICENSE in the lib/python3.11/site-packages over the .dist-info dir?

Copy link
Member

@murilo-cunha murilo-cunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I had it flipped. For some reason I thought you wanted to add the include, but this makes sense.

Thanks for spotting this and the contribution! 🚀

@murilo-cunha murilo-cunha merged commit e657a7d into datarootsio:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants