This repository has been archived by the owner on Feb 28, 2018. It is now read-only.
Elm refactor: performance and readability #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 09557ad on cuducos-elm-refactor into ** on master**. |
|
LGTM, naming it Reimbursement is much better than Document! |
rogeriochaves
approved these changes
Jan 15, 2017
| query | ||
| |> Dict.fromList | ||
| |> Dict.get "page" | ||
| |> Maybe.andThen (String.toInt >> Result.toMaybe) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite minor enhancements this PR is focused on enhancing performance and readability by:
Array(instead osList) to store data that needs to be accessed by index (the main reimbursement list, and reimbursement summaries in the same day and same subquota panels)Dict String String(instead ofList ( String, String )) to check and manipulate URL parameters (for example, whenever we need to check the hash from URL for apageparameter)In the minor enhancements list I'd mention: changing some data types, renaming things to match the current abstraction of CEAP, compiling settings, organizing imports, some clean up etc.