This repository has been archived by the owner on Mar 1, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is complimentary to #37:
settings
andadapter
modules can be helpful to make aCore
generic pipelinesettings
andadapter
module are just barely organized. Some ideas of improvements:name
property (sosettings.CLASSIFIERS
could be a simple list);settings.UNIQUE_IDS
andsettings.VALUE
) should be integrated to theadapter
— and maybeCore
will only require theadapter
(notsettings
);settings
module (it could be integrated in theadapter
).Hint: this talk about
class
objects in Python can be helpful.