Skip to content
This repository has been archived by the owner on Mar 1, 2018. It is now read-only.

WIP: Core obj handling the pipeline #38

Merged

Conversation

cuducos
Copy link
Collaborator

@cuducos cuducos commented Apr 18, 2017

This PR is complimentary to #37:

  • It exemplifies how can settings and adapter modules can be helpful to make a Core generic pipeline
  • It starts to handle what was called irregularities as suspicions for semantic sake

settings and adapter module are just barely organized. Some ideas of improvements:

  • Every classifier could have a name property (so settings.CLASSIFIERS could be a simple list);
  • Some general variables (settings.UNIQUE_IDS and settings.VALUE) should be integrated to the adapter — and maybe Core will only require the adapter (not settings);
  • Maybe in the future we don't even need the settings module (it could be integrated in the adapter).

Hint: this talk about class objects in Python can be helpful.

@coveralls
Copy link

Coverage Status

Coverage decreased (-81.8%) to 14.65% when pulling 054ddac on cuducos-creating-core-module into 40af34e on anaschwendler-creating-core-module.

@coveralls
Copy link

Coverage Status

Coverage decreased (-11.5%) to 84.95% when pulling a0351d1 on cuducos-creating-core-module into 40af34e on anaschwendler-creating-core-module.

@anaschwendler anaschwendler merged commit a0351d1 into anaschwendler-creating-core-module Apr 18, 2017
@anaschwendler anaschwendler deleted the cuducos-creating-core-module branch April 18, 2017 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants