Skip to content
This repository has been archived by the owner on Mar 1, 2018. It is now read-only.

Fix Docker command #98

Merged
merged 2 commits into from
Nov 4, 2017
Merged

Fix Docker command #98

merged 2 commits into from
Nov 4, 2017

Conversation

cuducos
Copy link
Collaborator

@cuducos cuducos commented Nov 4, 2017

What is the purpose of this Pull Request?

Docker instructions had a typo (br missing in the Docker Hub account name).

What was done to achieve this purpose?
Added the missing letters.

How to test if it really works?
Copy and paste the command from the README.md, execute it and check if it works.

Who can help reviewing it?
@anaschwendler

@anaschwendler
Copy link
Collaborator

Last review!

  1. Clone the project:
$ git clone git@github.com:datasciencebr/rosie.git
  1. Change to Rosie' folder:
$ cd rosie
  1. Change to the tested branch:
$ git checkout -b cuducos-fix-docker-command origin/cuducos-fix-docker-command
  1. Merge its content:
$ git merge master
  1. Run the new Docker commands:
$ docker build -t rosie .
$ docker run --rm -v /tmp/serenata-data:/tmp/serenata-data datasciencebr/rosie run federal_senate

The result:

rosie git:(cuducos-fix-docker-command) ls /tmp/serenata-data 
federal-senate-2008.csv          federal-senate-2011.csv          federal-senate-2014.csv          federal-senate-2017.csv
federal-senate-2008.xz           federal-senate-2011.xz           federal-senate-2014.xz           federal-senate-2017.xz
federal-senate-2009.csv          federal-senate-2012.csv          federal-senate-2015.csv          federal-senate-reimbursements.xz
federal-senate-2009.xz           federal-senate-2012.xz           federal-senate-2015.xz           invalidcnpjcpfclassifier.pkl
federal-senate-2010.csv          federal-senate-2013.csv          federal-senate-2016.csv          suspicions.xz
federal-senate-2010.xz           federal-senate-2013.xz           federal-senate-2016.xz

Done!

@anaschwendler anaschwendler merged commit 4171316 into master Nov 4, 2017
@anaschwendler anaschwendler deleted the cuducos-fix-docker-command branch November 4, 2017 22:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants