Skip to content
This repository has been archived by the owner on Mar 1, 2018. It is now read-only.

Removes ignore D4000 of linter. #99

Merged
merged 2 commits into from
Nov 6, 2017
Merged

Conversation

caduvieira
Copy link
Contributor

What is the purpose of this Pull Request?
Removes 'Ignore D4000" Maintainer and Label
See hadolint/hadolint#93 (comment)

How to test if it really works?
docker run --rm -i lukasmartinelli/hadolint - < Dockerfile

Who can help reviewing it?
@anaschwendler

@cuducos
Copy link
Collaborator

cuducos commented Nov 6, 2017

  1. Used GitHub instructions to pull the branch to my local machine:
    git checkout -b caduvieira-travis_fix master && git pull https://github.com/caduvieira/rosie.git travis_fix
  2. Ran the suggested command (used in the CI):
    docker run --rm -i lukasmartinelli/hadolint - < Dockerfile
  3. Got the following error:
container_linux.go:265: starting container process caused "exec: \"-\": executable file not found in $PATH"
docker: Error response from daemon: oci runtime error: container_linux.go:265: starting container process caused "exec: \"-\": executable file not found in $PATH".

Sounds like a weird Docker issue, not a problem with the PR. Any ideas on an workaround so I can test it? Tested with zsh and bash BTW…

@caduvieira
Copy link
Contributor Author

Sorry i forgot the '-' in the command

@cuducos
Copy link
Collaborator

cuducos commented Nov 6, 2017

Great then ; ) Done!

@cuducos cuducos merged commit 25a0eaf into okfn-brasil:master Nov 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants