Analysis of meals on speech days #172
Conversation
requirements.txt
Outdated
| @@ -1,2 +1,4 @@ | |||
| -e git+https://github.com/datasciencebr/serenata-toolbox.git@6126436#egg=serenata-toolbox | |||
There was a problem hiding this comment.
@cuducos You recently removed the -e from Rosie. Was for not saving it inside the project folder, right?
If that's the case, can you change for the version after @cuducos' commit?
There was a problem hiding this comment.
Yep. -e means editable mode, so it copies the package source code to your project. We don't need that here ; )
There was a problem hiding this comment.
Sure! I'll get that changed later on today 👍
requirements.txt
Outdated
| @@ -1,2 +1,4 @@ | |||
| git+https://github.com/datasciencebr/serenata-toolbox.git@6126436#egg=serenata-toolbox | |||
There was a problem hiding this comment.
@Irio @cuducos I've removed the -e but was wondering if you guys had any thoughts on keeping it locked to a version like I did here? I like that it makes things reproductible and makes it clear when we expect people to update the package on their local installations but I noticed you guys didn't do it on rosie 💭
There was a problem hiding this comment.
Very very personal opinion here: locking the version surely is a good thing, but I think it should be done in a neat way. It's a good point you raise here, I don't think we've pondered on it in this context… Anyway: a neat way would be to use GitHug tags, or (I prefer) uploading it to PyPI.
There was a problem hiding this comment.
yeah, uploading to pypi would be ideal, but a git tag might be the easiest way to move forward for now 💭
There was a problem hiding this comment.
@Irio: Any ideas? If the silence remains (drama 👑 ) I upload it to PyPI next week hahaha…
…to meals-on-speech-days
Conflicts:
requirements.txt
…mbursements Add info about deleted reimbursements to the UI
Related to GH-137
This also has the the bonus of setting up serenata_toolbox. It is only used for this notebook ATM but I can look into updating other stuff to make use of it at another day this or next week 🤘