Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added build directories and vim temporary files to .gitignore #145

Merged
merged 3 commits into from
Sep 21, 2017
Merged

Added build directories and vim temporary files to .gitignore #145

merged 3 commits into from
Sep 21, 2017

Conversation

rennerocha
Copy link
Member

This PR fixes #128

@coveralls
Copy link

coveralls commented Sep 12, 2017

Coverage Status

Coverage remained the same at 85.667% when pulling 29b22e7 on rennerocha:gitignore-issue into f30d0a8 on datasciencebr:master.

Copy link
Collaborator

@cuducos cuducos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. As our CI handles the PyPI deploy we need either a [skip ci] in the commit message or a version bump (it's OK to version bump, no worries about numbers getting too big!)

@lipemorais
Copy link
Contributor

Hey, @rennerocha ! I can not see the vim temporary files. Is this title still updated?

@cuducos
Copy link
Collaborator

cuducos commented Sep 19, 2017

@lipemorais The point was not the vim files (this was an extra I guess). The point (descirbed in #128) was the dist/ and build/ ; )

@rennerocha would you mind updating the branch (from master) and adding a patch version bump so we cam merge this?

@rennerocha
Copy link
Member Author

vim files are an extra ... as I use vim, it was bothering me to have its files there :-)
updated the version now

@coveralls
Copy link

Coverage Status

Coverage decreased (-28.2%) to 57.496% when pulling 37570ce on rennerocha:gitignore-issue into 7790572 on datasciencebr:master.

@cuducos cuducos merged commit 37570ce into okfn-brasil:master Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deploy artifacts to .gitignore
4 participants