Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dataset with congresspeople social media account #178

Merged
merged 3 commits into from Feb 6, 2018

Conversation

cuducos
Copy link
Collaborator

@cuducos cuducos commented Feb 5, 2018

What is the purpose of this Pull Request?

The purpose is to update the dataset with congresspeople Twitter accounts, as we have two reports of new accounts (here and here).

What was done to achieve this purpose?

I updated the Google Spreadsheet and generated a new .xz version of the CSV. The file is already in S3.

How to test if it really works?

Try to download the latest datasets (as in the README.md) and check if a file with today's date and the Twitter account data is downloaded within the bunch. The fle name is 2018-02-05-congresspeople-social-accounts.xz.

Who can help reviewing it?

@anaschwendler @jtemporal @Irio

Copy link
Collaborator

@jtemporal jtemporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtemporal
Copy link
Collaborator

The fle name is 2017-06-11-congresspeople-social-accounts.xz.

The correct file name is: 2018-02-05-congresspeople-social-accounts.xz

Did exactly what @cuducos said on the How to test if it really works? section (plus the file name correctio). It works =)

@cuducos
Copy link
Collaborator Author

cuducos commented Feb 6, 2018

The correct file name is: 2018-02-05-congresspeople-social-accounts.xz

True story 🥂

@anaschwendler anaschwendler merged commit d602844 into master Feb 6, 2018
@anaschwendler anaschwendler deleted the cuducos-update-twitter-accounts-dataset branch February 6, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants