Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve ngrams-unbiasing performance #70

Closed
thanasions opened this issue Oct 9, 2018 · 0 comments
Closed

improve ngrams-unbiasing performance #70

thanasions opened this issue Oct 9, 2018 · 0 comments
Assignees
@thanasions @IanGrimstead
Labels
enhancement New feature or request
Projects
pyGrams

Comments

@thanasions
Copy link
Contributor

Opted for binary search over the feature set, as it is cheaper than the other option of linear search through the unsorted non-zero term-features.

The best option would be to iterate the sparse matrix row-wise with sorted feature names, can we do it?
@thanasions thanasions added the enhancement New feature or request label Oct 9, 2018
@thanasions thanasions added this to To do in pyGrams via automation Oct 9, 2018
@thanasions thanasions moved this from To do to Needs review in pyGrams Oct 18, 2018
@thanasions thanasions moved this from Needs review to Reviewer approved in pyGrams Oct 18, 2018
@thanasions thanasions moved this from Reviewer approved to Done in pyGrams Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanasions thanasions

@IanGrimstead IanGrimstead

Labels
enhancement New feature or request
Projects
No open projects
pyGrams
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thanasions @IanGrimstead