Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAVA-942: Incorrect implementation of UserType.hashCode() #475

Closed
wants to merge 1 commit into from

Conversation

adutra
Copy link
Contributor

@adutra adutra commented Oct 8, 2015

No description provided.

@tolbertam
Copy link
Contributor

Looks good to me 👍 (other than small comment about imports)! When implementing tests using equalsverifier in #471, it also caught this by detecting Arrays.hashCode was not used on byIdxl. I attempted a fix, but I like your approach better :).

@tolbertam
Copy link
Contributor

Just realized, should this be fixed on 2.1 as well?

@tolbertam
Copy link
Contributor

Another thing I noticed was that 'name' is not included in equals, but is in hashCode. Do you think equals should be updated as well to incorporate that?

@adutra
Copy link
Contributor Author

adutra commented Oct 8, 2015

Thank you for all the (very good) remarks - I squashed (sorry) my previous commit.
As for this being applied to 2.1, I think it should in theory, but it is more urgent for 2.2; and I'm not sure we have enough time to commit to 2.1 and merge upstream. Maybe could we cherry-pick this commit into 2.1?

@olim7t
Copy link
Contributor

olim7t commented Oct 11, 2015

Closing to reopen against 3.0 (#483)

@olim7t olim7t closed this Oct 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants