Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes to support columns list for GET queries. #646

Closed
wants to merge 1 commit into from
Closed

Added changes to support columns list for GET queries. #646

wants to merge 1 commit into from

Conversation

vagifzeynalov
Copy link

Example:

public T get(K1 pk1, K2 pk2, Set<String> columns) {
    return mapper().get(pk1, pk2, columns);
}

final Entity entiry = dao.get(key1, key2, ImmutableSet.of("col1", "col2"));

Example:
public T get(K1 pk1, K2 pk2, Set<String> columns) {
    return mapper().get(pk1, pk2, columns);
}

final Entity entiry = dao.get(key1, key2, ImmutableSet.of("col1",
"col2"));
@olim7t
Copy link
Contributor

olim7t commented May 10, 2016

Is the goal to restrict the columns in the SELECT statement?
One problem I see is that Set<String> is a valid type for a partition key component, for example with this table:

CREATE TABLE foo(s frozen<set<text>> PRIMARY KEY );

@vagifzeynalov
Copy link
Author

vagifzeynalov commented May 10, 2016

Yes, you've got the goal right.
Actually it could be some special class for columns, like Columns extends HashSet< String >, or even List instead... I don't know what is the best in terms of the compatibility.
Do you want me to change it, or you can change it by yourself?

@adutra
Copy link
Contributor

adutra commented Feb 17, 2017

Closing in favor of #645 as this should target a minor release, not a patch one. Thanks!

@adutra adutra closed this Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants