[#3489] improvement(hive-catalog): Add user authentication e2e test for Hive catalog #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
commented
May 23, 2024
| @@ -58,7 +58,7 @@ public Object doAs( | |||
| ops.getClientPool() | |||
| .run( | |||
| client -> { | |||
| return client.getDelegationToken(realUser.getUserName(), principal.getName()); | |||
| return client.getDelegationToken(principal.getName(), realUser.getUserName()); | |||
There was a problem hiding this comment.
This a bug, just fixed it by the way.
Got it. |
It's now ready for review. |
|
@qqqttt123 |
jerryshao
reviewed
May 27, 2024
| .dropTable(NameIdentifier.of(METALAKE_NAME, CATALOG_NAME, SCHEMA_NAME, "new_table")); | ||
|
|
||
| // Drop schema | ||
| catalog.asSchemas().dropSchema(SCHEMA_NAME, true); |
There was a problem hiding this comment.
Add assertions about what you expected here. not just simply write some codes here, it is a test code, you have to verify something, not blindly throw exceptions if it fails.
jerryshao
approved these changes
May 27, 2024
yuqi1129
added a commit
to yuqi1129/gravitino
that referenced
this pull request
May 27, 2024
…e2e test for Hive catalog (datastrato#3525) Add e2e tests to test end-to-end user authentication. Verify that user authentication works Fix: datastrato#3489 N/A Test locally.
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…e2e test for Hive catalog (datastrato#3525) ### What changes were proposed in this pull request? Add e2e tests to test end-to-end user authentication. ### Why are the changes needed? Verify that user authentication works Fix: datastrato#3489 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Test locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add e2e tests to test end-to-end user authentication.
Why are the changes needed?
Verify that user authentication works
Fix: #3489
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Test locally.